Skip to content

gguf-py : Fix disconnect-before-connect crash on Kubuntu #13569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

gguf-py : Fix disconnect-before-connect crash on Kubuntu #13569

merged 1 commit into from
May 15, 2025

Conversation

@danielzgtg
Copy link
Contributor

@danielzgtg danielzgtg commented May 15, 2025

This fixes the crash upon load with venvs created with --system-site-packages to use python3-pyside6.qtwidgets=python3-pyside6.qtwidgets=6.6.2-4 from Kubuntu 24.10. Using system Qt is not merely æsthetic; I need Qt to use KDE's file picker so that hidden folders are openable. For users on other platforms, this doesn't change anything or just improves correctness.

Before

$ gguf-editor-gui
Traceback (most recent call last):
  File "/home/home/CLionProjects/llamacpprocm/gguf-py/gguf/scripts/gguf_editor_gui.py", line 913, in load_file
    self.load_metadata()
  File "/home/home/CLionProjects/llamacpprocm/gguf-py/gguf/scripts/gguf_editor_gui.py", line 948, in load_metadata
    self.metadata_table.itemChanged.disconnect(self.on_metadata_changed)
RuntimeError: Failed to disconnect (<bound method GGUFEditorWindow.on_metadata_changed of <gguf.scripts.gguf_editor_gui.GGUFEditorWindow(0x3fe2f560) at 0x7f5754e84480>>) from signal "itemChanged(QTableWidgetItem*)".

After

I was able to view gemma-3-4b-it-Q4_K_M.gguf successfully.

@danielzgtg
gguf-py : Fix disconnect-before-connect
8790427 
The bug caused a crash upon load with venvs created with
--system-site-packages to use
python3-pyside6.qtwidgets=python3-pyside6.qtwidgets=6.6.2-4
from Kubuntu 24.10.
@github-actions github-actions bot added the python python script changes label May 15, 2025
@CISC CISC merged commit 07ad2b6 into ggml-org:master May 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CISC CISC CISC approved these changes

Assignees

No one assigned

Labels

python python script changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielzgtg @CISC